Re: [PATCH] Support environment variables in config file

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jun 4, 2007, 15:57 UTC
Message-ID: <Pine.LNX.4.64.0706041657210.4046@racer.site>
In-Reply-To: <20070604072707.GE16637@admingilde.org>

Hi,

On Mon, 4 Jun 2007, Martin Waitz wrote:

> Do you think the approach is ok?

I actually would like it more if the calling program did the interpolation itself.

So, for example if you want a script to access whatever.my.url, and want to allow to interpolate any environment variable, why not

	url=$(eval $(git config whatever.my.url))

I am just hesitant to change the existing behaviour, and possibly introduce weird breakages. (There could even be some unwanted env leakages in programs like gitweb...)

Ciao, Dscho