Re: [PATCH] Support environment variables in config file

From: Martin Waitz <tali@admingilde.org>
Date: Jun 4, 2007, 17:47 UTC
Message-ID: <20070604174719.GH16637@admingilde.org>
In-Reply-To: <Pine.LNX.4.64.0706041657210.4046@racer.site>

hoi :)

On Mon, Jun 04, 2007 at 04:57:35PM +0100, Johannes Schindelin wrote:

> I actually would like it more if the calling program did the interpolation 
> itself.

That's another possibility, perhaps along the line of git_config_int.

> So, for example if you want a script to access whatever.my.url, and want 
> to allow to interpolate any environment variable, why not
> 
> 	url=$(eval $(git config whatever.my.url))

Well, complete shell syntax does too much: it also supports $() and friends.

> I am just hesitant to change the existing behaviour, and possibly 
> introduce weird breakages. (There could even be some unwanted env leakages 
> in programs like gitweb...)

exactly.

So should we simply update semantics of config variables to not require any environment variables?

-- 
Martin Waitz