git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Make git-k an alias to gitk

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
May 30, 2007, 03:03 UTC
Message-ID
<Pine.LNX.4.64.0705300402050.4011@racer.site>
In-Reply-To
<fcaeb9bf0705291145q6a0d276o6a94ded3c3e0b6d1@mail.gmail.com>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
On Tue, 29 May 2007, Nguyen Thai Ngoc Duy wrote:
	> On 5/29/07, Johannes Sixt <J.Sixt@eudaptics.com> wrote:
	> > Nguyen Thai Ngoc Duy wrote:
	> > > I'd suggest create a small C wrapper to launch gitk. It 
	> > > would be much easier that way IMHO.
	> > 
	> > Doh! You're right! It's even there already, right before our 
	> > eyes:
	> > 
	> > pointy..clicky..pointy..clicky  (aka: cp gitk git-k)
	> > 
	> > $ git k
	> > 
	> > :)
	> 
	> Maybe we should teach git.c to try gitk if git-k is not found ;)
	Something like this?
 Makefile |    2 +-
 git.c    |    6 ++++++
 2 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index 5f94630..01ab1ff 100644
--- a/Makefile
+++ b/Makefile
@@ -262,7 +262,7 @@ EXTRA_PROGRAMS =
 BUILT_INS = \
 	git-format-patch$X git-show$X git-whatchanged$X git-cherry$X \
 	git-get-tar-commit-id$X git-init$X git-repo-config$X \
-	git-fsck-objects$X git-cherry-pick$X \
+	git-fsck-objects$X git-cherry-pick$X git-k$X \
 	$(patsubst builtin-%.o,git-%$X,$(BUILTIN_OBJS))
 
 # what 'all' will build and 'install' will install, in gitexecdir
diff --git a/git.c b/git.c
index 04eb344..53d81e9 100644
--- a/git.c
+++ b/git.c
@@ -216,6 +216,11 @@ static int handle_alias(int *argcp, const char ***argv)
 	return ret;
 }
 
+static int cmd_gitk(int argc, const char **argv, const char *prefix)
+{
+	return execv("gitk", (char *const *)argv);
+}
+
 const char git_version_string[] = GIT_VERSION;
 
 #define RUN_SETUP	(1<<0)
@@ -274,6 +279,7 @@ static void handle_internal_command(int argc, const char **argv, char **envp)
 		{ "help", cmd_help },
 		{ "init", cmd_init_db },
 		{ "init-db", cmd_init_db },
+		{ "k", cmd_gitk },
 		{ "log", cmd_log, RUN_SETUP | USE_PAGER },
 		{ "ls-files", cmd_ls_files, RUN_SETUP },
 		{ "ls-tree", cmd_ls_tree, RUN_SETUP },
-- 
1.5.2.2641.g404de-dirty
Previous: Nguyen Thai Ngoc DuyNext: Johannes Sixt
Message 59 of 69 in “GIT on MinGW problem”
  1. Aaron GrayMay 12, 2007
  2. Junio C HamanoMay 12, 2007
  3. Aaron GrayMay 12, 2007
  4. Han-Wen NienhuysMay 12, 2007
  5. Johannes SixtMay 25, 2007
  6. Marco CostalbaMay 25, 2007
  7. Johannes SchindelinMay 25, 2007
  8. Johannes SixtMay 25, 2007
  9. Han-Wen NienhuysMay 26, 2007
  10. Johannes SchindelinMay 26, 2007
  11. Han-Wen NienhuysMay 27, 2007
  12. Johannes SchindelinMay 27, 2007
  13. Han-Wen NienhuysMay 27, 2007
  14. NixMay 28, 2007
  15. Han-Wen NienhuysMay 27, 2007
  16. Aaron GrayMay 25, 2007
  17. Han-Wen NienhuysMay 26, 2007
  18. Johannes SchindelinMay 26, 2007
  19. Junio C HamanoMay 26, 2007
  20. Johannes SchindelinMay 26, 2007
  21. Han-Wen NienhuysMay 26, 2007
  22. Jakub NarebskiMay 26, 2007
  23. Han-Wen NienhuysMay 27, 2007
  24. Shawn O. PearceMay 27, 2007
  25. Han-Wen NienhuysMay 27, 2007
  26. Steven GrimmMay 27, 2007
  27. Jakub NarebskiMay 27, 2007
  28. Han-Wen NienhuysMay 27, 2007
  29. Johannes SchindelinMay 28, 2007
  30. Han-Wen NienhuysMay 28, 2007
  31. Johannes SchindelinMay 27, 2007
  32. Han-Wen NienhuysMay 27, 2007
  33. GIT on MinGW, with tcltk for gitkHan-Wen Nienhuys, May 27, 2007
  34. Aaron GrayMay 27, 2007
  35. Han-Wen NienhuysMay 27, 2007
  36. Aaron GrayMay 27, 2007
  37. Aaron GrayMay 27, 2007
  38. Han-Wen NienhuysMay 27, 2007
  39. Aaron GrayMay 27, 2007
  40. Han-Wen NienhuysMay 27, 2007
  41. Aaron GrayMay 27, 2007
  42. Johannes SchindelinMay 27, 2007
  43. Johannes SixtMay 29, 2007
  44. Han-Wen NienhuysMay 27, 2007
  45. Johannes SixtMay 29, 2007
  46. Marius Storm-OlsenMay 29, 2007
  47. Johannes SixtMay 29, 2007
  48. Han-Wen NienhuysMay 29, 2007
  49. Johannes SixtMay 29, 2007
  50. Johannes SchindelinMay 29, 2007
  51. Marius Storm-OlsenMay 29, 2007
  52. Johannes SixtMay 29, 2007
  53. Marius Storm-OlsenMay 29, 2007
  54. Johannes SchindelinMay 29, 2007
  55. Johannes SixtMay 29, 2007
  56. Nguyen Thai Ngoc DuyMay 29, 2007
  57. Johannes SixtMay 29, 2007
  58. Nguyen Thai Ngoc DuyMay 29, 2007
  59. Make git-k an alias to gitkJohannes Schindelin, May 30, 2007
  60. Johannes SixtMay 30, 2007
  61. Han-Wen NienhuysMay 30, 2007
  62. Johannes SchindelinMay 30, 2007
  63. Shawn O. PearceMay 30, 2007
  64. Git wrapper: add --redirect-stderr optionJohannes Schindelin, May 30, 2007
  65. Shawn O. PearceMay 30, 2007
  66. Johannes SchindelinMay 30, 2007
  67. Shawn O. PearceMay 30, 2007
  68. Johannes SchindelinMay 30, 2007
  69. Johannes SchindelinMay 27, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.