Re: [RFC] Fourth round of support for cloning submodules
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- May 24, 2007, 18:07 UTC
- Message-ID
- <Pine.LNX.4.64.0705241907021.4648@racer.site>
- In-Reply-To
- <20070524174252.GT942MdfPADPa@greensroom.kotnet.org>
Hi,
On Thu, 24 May 2007, Sven Verdoolaege wrote:
Show 14 quoted lines
> On Thu, May 24, 2007 at 02:52:25PM +0100, Johannes Schindelin wrote:
> > It is not that expensive to just give the SHA-1 with the URL, and to
> > introduce a new namespace, say
> >
> > 3f... submodule/path^{URL:blablub}
> >
> > to say that the submodule which is connected in "HEAD:path" is available
> > with the URL "blablub" and just so happens to be at commit "3f..." at the
> > moment. Heck, you can even use this instead of expensive fetches to verify
> > up-to-date, and even more, you can make sure that you are as up-to-date as
> > the remote supermodule.
>
> What about all the other branches?
> Also, the submodule may not even be in any of the tips of the branches.Okay, bad idea.
Show 6 quoted lines
> > Without some very intrusive surgery into the transport code of Git, in 22 > > patches, which I am not at all comfortable with. > > You're not comfortable with the number or with the patches? > There's only about four or five that deal with this git-config stuff > and any other mechanism would have to implemented as well.
If it was even only one, which is as intrusive, I would still be uncomfortable. And yes, the large number does not make me want to review the series either.
Ciao, Dscho