Re: [PATCH 11/22] entry.c: optionally checkout submodules

From: Sven Verdoolaege <skimo@kotnet.org>
Date: May 24, 2007, 07:27 UTC
Message-ID: <20070524072758.GG942MdfPADPa@greensroom.kotnet.org>
In-Reply-To: <20070524071819.GN28023@spearce.org>

On Thu, May 24, 2007 at 03:18:19AM -0400, Shawn O. Pearce wrote:

Show 16 quoted lines

> Alex Riesen <raa.lkml@gmail.com> wrote:
> > On 5/24/07, skimo@liacs.nl <skimo@liacs.nl> wrote:
> > 
> > >+       args[argc++] = "checkout";
> > >+       if (state->force)
> > >+           args[argc++] = "-f";
> > >+       args[argc++] = sha1_to_hex(ce->sha1);
> > >+       args[argc] = NULL;
> > 
> > You should consider passing "-v" if the superprojects read-tree
> > had it. Some submodules will be annoyingly big
> 
> In 1.5.2 that -v shouldn't be necessary.  The read-tree should
> start a timer, and if it has not reached 50% of its processing
> within 2 seconds it starts showing progress.  Unless !istty(2),
> in which case it just sits there, chugging away at your drive.

Well, git-checkout.sh has this line:

    merge_error=$(git-read-tree $submodules -m -u --exclude-per-directory=.gitignore $old $new 2>&1) || (

so actually you don't see anything right now when a submodule checkout is going on during a checkout of the supermodule.

skimo