Re: [PATCH] Teach mailsplit about Maildir's
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- May 21, 2007, 12:56 UTC
- Message-ID
- <Pine.LNX.4.64.0705211355181.6410@racer.site>
- In-Reply-To
- <7vd50uj29r.fsf@assigned-by-dhcp.cox.net>
Hi,
On Sun, 20 May 2007, Junio C Hamano wrote:
Show 29 quoted lines
> "Fernando J. Pereda" <ferdy@gentoo.org> writes:
>
> > - ret = split_mbox(argp, dir, allow_bare, nr_prec, nr);
> > + while (*argp) {
> > + const char *arg = *argp++;
> > + struct stat argstat;
> > +
> > + if (arg[0] == '-' && arg[1] == 0) {
> > + ret |= split_mbox(arg, dir, allow_bare, nr_prec, nr);
> > + continue;
> > + }
> > +
> > + if (stat(arg, &argstat) == -1) {
> > + error("cannot stat %s (%s)", arg, strerror(errno));
> > + return 1;
> > + }
> > +
> > + if (S_ISDIR(argstat.st_mode))
> > + ret |= split_maildir(arg, dir, nr_prec, nr);
> > + else
> > + ret |= split_mbox(arg, dir, allow_bare, nr_prec, nr);
> > + }
> > +
> > if (ret != -1)
> > printf("%d\n", ret);
> >
>
> No kidding. ret |= stuff and then printf("%d\n", ret) would not
> give us the number of commit e-mails on the standard output.Should we not just stop when split_maildir() or split_mbox() returns -1? And yes, we'd probably need a second variable to do take the return value.
Ciao, Dscho