Re: [PATCH] Allow user to specify mailbox format for mailsplit

From: Alex Riesen <raa.lkml@gmail.com>
Date: May 22, 2007, 22:04 UTC
Message-ID: <20070522220443.GK30871@steel.home>
In-Reply-To: <7vwsz1bw8y.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano, Tue, May 22, 2007 01:19:25 +0200:

Show 10 quoted lines

> Alex Riesen <raa.lkml@gmail.com> writes:
> 
> > If the argument ends with a slash - assume it is a Maildir and try to
> > create it. Otherwise - it is an mbox.
> 
> Sorry, I am lost here.  git-mailsplit is to read an existing
> mbox and split the pieces of e-mail into the specified output
> directory.  The recent Maildir support is to make it read pieces
> of e-mails from an existing Maildir (which presumably have bunch
> of files that store e-mail), isn't it?

Oh... Fernando, I'm very sorry. I never used mailsplit and didn't even gave a second thought about its name. For reasons unknown, I assumed the mbox/maildir argument is for the output. Must be all the ozone depletion and the cosmic rays now causing glitches in programmers brains...

Show 5 quoted lines

> If the patch were about creating a new _output_ directory (that
> is, "dir" in cmd_mailsplit), I would understand what you are
> trying to do, but why would you even want to create the input
> Maildir in that loop (I take that your patch is on top of
> Fernando's patch)?

Yes, but don't apply it! :)