git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: "git-diff -p :/anything" always segfaults

From
Linus Torvalds <torvalds@linux-foundation.org>
Date
Mar 12, 2007, 16:22 UTC
Message-ID
<Pine.LNX.4.64.0703120921080.9690@woody.linux-foundation.org>
In-Reply-To
<Pine.LNX.4.64.0703120900300.9690@woody.linux-foundation.org>
On Mon, 12 Mar 2007, Linus Torvalds wrote:
> 
> Otherwise, please apply something like this, which also fixes the return 
> value. We should return -1 on error!
Btw, I didn't remove the 
	if (!commit)
		break;

but I should have. It doesn't actually matter (since it will never trigger), but it adds to the confusion around pop_most_recent_commit.

		Linus
Previous: Linus TorvaldsNext: Junio C Hamano
Message 6 of 7 in “"git-diff -p :/anything" always segfaults”
  1. Jim MeyeringMar 11, 2007
  2. Johannes SchindelinMar 11, 2007
  3. Linus TorvaldsMar 11, 2007
  4. Junio C HamanoMar 11, 2007
  5. Linus TorvaldsMar 12, 2007
  6. Linus TorvaldsMar 12, 2007
  7. Junio C HamanoMar 12, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.