From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Mon, 12 Mar 2007 16:22:09 GMT
Subject: Re: "git-diff -p :/anything" always segfaults
Message-ID: <Pine.LNX.4.64.0703120921080.9690@woody.linux-foundation.org>
In-Reply-To: <Pine.LNX.4.64.0703120900300.9690@woody.linux-foundation.org>



On Mon, 12 Mar 2007, Linus Torvalds wrote:
> 
> Otherwise, please apply something like this, which also fixes the return 
> value. We should return -1 on error!

Btw, I didn't remove the 

	if (!commit)
		break;

but I should have. It doesn't actually matter (since it will never 
trigger), but it adds to the confusion around pop_most_recent_commit.

		Linus