Re: [PATCH] shortlog: prompt when reading from terminal by mistake

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Mar 8, 2007, 17:31 UTC
Message-ID: <Pine.LNX.4.64.0703080928580.10832@woody.linux-foundation.org>
In-Reply-To: <Pine.LNX.4.63.0703081755500.22628@wbgn013.biozentrum.uni-wuerzburg.de>

On Thu, 8 Mar 2007, Johannes Schindelin wrote:

> 
> How about something totally different: "git log --shortlog". I.e.

Sure, but this is even worse, because the way you wrote the patch, now

	git log --shortlog

will act as a filter too, which is even *more* confusing.

You also broke something even more fundamental. Try this:

	git log -- --shortlog

with your patch ;)

But yeah, if "cmd_shortlog()" worked like "git log" (at least if it sees the "--shortlog" flag) and with that obvious filename parsing thing fixed, that thing would be fine.

			Linus