Re: [PATCH] shortlog: prompt when reading from terminal by mistake
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Mar 8, 2007, 13:04 UTC
- Message-ID
- <Pine.LNX.4.63.0703081344140.22628@wbgn013.biozentrum.uni-wuerzburg.de>
- In-Reply-To
- <7vhcsw9h8p.fsf@assigned-by-dhcp.cox.net>
Hi,
On Thu, 8 Mar 2007, Junio C Hamano wrote:
Show 14 quoted lines
> I was trying to see who have been active recently to find GSoC > mentor candidates by running: > > $ git shortlog -s -n --since=4.months | head -n 20 > > After waiting for about 20 seconds, I started getting worried, > thinking that the recent revision traversal updates might have > had an unintended side effect. > > Not so. "git shortlog" acts as a filter when no revs are given, > unlike "git log" which defaults to HEAD. It was reading from > its standard input. > > Signed-off-by: Junio C Hamano <junkio@cox.net>
Acked-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Show 6 quoted lines
> Arguably because --since=4.months clearly states I am > expecting it to start digging from somewhere, it would be > more sensible to default to HEAD in this case. I suspect it > might be as simple as checking argc before we call > setup_revisions() and pass "HEAD" as the default parameter to > it, but it is getting late here.
Hm. Better check argc _afterwards_, and if it changed, but no pending object was there, add "HEAD".
Ciao, Dscho