git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] Allow fetch-pack to decide keeping the fetched pack without exploding

From
Linus Torvalds <torvalds@linux-foundation.org>
Date
Jan 23, 2007, 16:15 UTC
Message-ID
<Pine.LNX.4.64.0701230809440.32200@woody.linux-foundation.org>
In-Reply-To
<Pine.LNX.4.63.0701231129501.22628@wbgn013.biozentrum.uni-wuerzburg.de>
On Tue, 23 Jan 2007, Johannes Schindelin wrote:
> 
> P.S.: These patches make me dream of yet another diff format enhancement: 
> code moves!
It's basically impossible.
Why? You need the context. 

In a _context_less_ diff, it's fairly trivial to indicate code movement: you just say "move bytes x-y into z". However, if you want anything approaching readability and safety, you want context, and that automatically means that you need to have the stuff around the context, which in turn means that you can't sanely do that.

Sure, you could do a diff that has the *context* repeated around the code that moves (and not actually quoting all the movement itself, except for the first and last three lines or something), but that would be really unreadable. A lot more unreadable than what we have now, with delete+add chunks.

> Of course, for this to be really usable, you'd also have to 
> automatically determine indent changes...

Indeed. Much code movement isn't just pure data movement, it's re-indentation too. Making the thing even less tractable.

In other words - you can do it (and we _do_ do it) when you don't do diffs at all, but deltas. Our deltas actually do contain block movement. But diffs? Forget about it.

> You may say I'm a dreamer. But I'm not the only one...
I am the walrus.
		Linus
Previous: Shawn O. PearceNext: David Kågedal
Message 62 of 70 in “[Announce] GIT v1.5.0-rc2”
  1. Junio C HamanoJan 21, 2007
  2. Jakub NarebskiJan 21, 2007
  3. Junio C HamanoJan 21, 2007
  4. Johannes SchindelinJan 21, 2007
  5. Bill LearJan 23, 2007
  6. Johannes SchindelinJan 23, 2007
  7. Bill LearJan 23, 2007
  8. Uwe Kleine-KönigJan 23, 2007
  9. Bill LearJan 23, 2007
  10. Uwe Kleine-KönigJan 24, 2007
  11. Johannes SchindelinJan 23, 2007
  12. Peter BaumannJan 23, 2007
  13. Bill LearJan 23, 2007
  14. Linus TorvaldsJan 23, 2007
  15. Mark NudelmanJan 24, 2007
  16. Linus TorvaldsJan 24, 2007
  17. Linus TorvaldsJan 24, 2007
  18. Junio C HamanoJan 24, 2007
  19. Mark NudelmanMar 27, 2007
  20. Junio C HamanoJan 21, 2007
  21. Bill LearJan 21, 2007
  22. Bill LearJan 21, 2007
  23. MichaelJan 21, 2007
  24. Johannes SchindelinJan 21, 2007
  25. Jakub NarebskiJan 21, 2007
  26. Johannes SchindelinJan 21, 2007
  27. Jakub NarebskiJan 21, 2007
  28. Willy TarreauJan 21, 2007
  29. Jakub NarebskiJan 21, 2007
  30. Junio C HamanoJan 21, 2007
  31. H. Peter AnvinJan 21, 2007
  32. Nicolas PitreJan 22, 2007
  33. Horst H. von BrandJan 21, 2007
  34. Junio C HamanoJan 22, 2007
  35. Horst H. von BrandJan 21, 2007
  36. Junio C HamanoJan 21, 2007
  37. Johannes SchindelinJan 21, 2007
  38. Jakub NarebskiJan 21, 2007
  39. Johannes SchindelinJan 21, 2007
  40. Jakub NarebskiJan 21, 2007
  41. Johannes SchindelinJan 21, 2007
  42. Jakub NarebskiJan 21, 2007
  43. Junio C HamanoJan 22, 2007
  44. Junio C HamanoJan 22, 2007
  45. 1/2 Refactor the pack header reading function out of receive-pack.cJunio C Hamano, Jan 23, 2007
  46. 2/2 Allow fetch-pack to decide keeping the fetched pack without explodingJunio C Hamano, Jan 23, 2007
  47. Johannes SchindelinJan 23, 2007
  48. Jakub NarebskiJan 23, 2007
  49. code movements in diffs, was Re: [PATCH 2/2] Allow fetch-pack to decide keeping the fetched pack without explodingJohannes Schindelin, Jan 23, 2007
  50. Nicolas PitreJan 23, 2007
  51. fetch-pack: remove --keep-auto and make it the default.Junio C Hamano, Jan 25, 2007
  52. Johannes SchindelinJan 25, 2007
  53. Junio C HamanoJan 25, 2007
  54. Johannes SchindelinJan 25, 2007
  55. Junio C HamanoJan 26, 2007
  56. Allow non-developer to clone, checkout and fetch easier.Junio C Hamano, Jan 26, 2007
  57. Alex RiesenJan 26, 2007
  58. Johannes SixtJan 26, 2007
  59. Consolidate {receive,fetch}.unpackLimitJunio C Hamano, Jan 25, 2007
  60. Nicolas PitreJan 25, 2007
  61. Shawn O. PearceJan 25, 2007
  62. Linus TorvaldsJan 23, 2007
  63. David KågedalJan 23, 2007
  64. Johannes SchindelinJan 23, 2007
  65. Jakub NarebskiJan 23, 2007
  66. Carl WorthJan 22, 2007
  67. Junio C HamanoJan 22, 2007
  68. Carl WorthJan 23, 2007
  69. Jakub NarebskiJan 22, 2007
  70. Junio C HamanoJan 22, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.