Re: [Announce] GIT v1.5.0-rc2

From: Junio C Hamano <junkio@cox.net>
Date: Jan 21, 2007, 10:52 UTC
Message-ID: <7vwt3g3b5b.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <eovccc$usc$1@sea.gmane.org>

Jakub Narebski <jnareb@gmail.com> writes:

> By the way, was the pager configured to saner values, so "git diff"
> on a repository with no changes does not output empty page?

That's been set to the right way since commit 0abc0260 (October 22, 2006, v1.4.3.2~6) as far as I know.

> What about my Documentation/config.txt changes?

I was not sure about that one, given a lot of commentary in your message, suggesting more research and revision is needed, like these...

Show 21 quoted lines

>>> +All the other lines are recognized as setting variables, in the form
>>> +'name = value'. If there is no equal sign on the line, the entire line
>>> +is taken as 'name' and the variable is recognized as boolean "true".
>>> +Variable names are case insensitive.
>> 
>> They cannot contain anything else than alphanumeric characters, in 
>> particular no whitespace.
>
> It is mentioned above "Syntax" section, but perhaps it should be repeated.
> I haven't took a look at code to check what values for section names and
> for key/variable names are allowed.
> ...
>> One thing that left me puzzled after reading the description was
>> what a user can do with "subsection".  It is unclear from the
>> description if [section "sub.section"], [section "sub.sec=ti.on"]
>> or worse yet, [section "sub\nsection with an embbedded LF"] are
>> allowed.  The rest seemed sane.
>
> I'm not sure what is allowed in section name, and in subsection name,
> so for now I have left it as is. I can amend this commit, or add new
> commit explaining this.