Re: Fix approxidate() to understand more extended numbers

From: Linus Torvalds <torvalds@osdl.org>
Date: Sep 29, 2006, 06:42 UTC
Message-ID: <Pine.LNX.4.64.0609282330440.3952@g5.osdl.org>
In-Reply-To: <7vd59fp5b9.fsf@assigned-by-dhcp.cox.net>

On Thu, 28 Sep 2006, Junio C Hamano wrote:

Show 11 quoted lines

> Linus Torvalds <torvalds@osdl.org> writes:
> 
> > On Thu, 28 Sep 2006, Morten Welinder wrote:
> >>
> >> Just don't hack at 12am or 12pm.
> >
> > I think 12pm is correct, but 12am probably isn't (12am should _subtract_ 
> > 12, while 12pm does _not_ add 12).
> 
> But you have "if (hour > 0 && hour < 12)" in both am and pm so
> assignment to tm would not trigger...

That's not the point.

If you write

	12:30 am

you really _should_ subtract 12, leaving you with 0:30. We don't. So we end up with a 24-hour time of 12:30, which is obviously _pm_, and wrong.

And "12 am" or "12 pm" doesn't work at all.

> > That said, I have a rice cooker that avoids the problem by saying "0:10 PM" 
> > for ten minutes past midday ;)
> 
> You eat rice?

Ok, is it just me, or is that just a very odd question?

I can see the question "You eat uni?". That really _does_ take a bit of getting used to. And Natto I really _really_ don't see the point of.

But rice? Afaik, it's the most common food-staple in the world. It's not exactly odd and exotic..

Show 5 quoted lines

> > Of course, all sane and civilized countries just use 24-hour format 
> > anyway.
> 
> You are referring to the US, but neither is Japan sane nor
> civilized ;-).

Yeah, well, they've been learning bad habits. But at least they are metric.

		Linus