Re: Fix approxidate() to understand more extended numbers

From: Junio C Hamano <junkio@cox.net>
Date: Sep 29, 2006, 06:14 UTC
Message-ID: <7vd59fp5b9.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.64.0609282300190.3952@g5.osdl.org>

Linus Torvalds <torvalds@osdl.org> writes:

Show 6 quoted lines

> On Thu, 28 Sep 2006, Morten Welinder wrote:
>>
>> Just don't hack at 12am or 12pm.
>
> I think 12pm is correct, but 12am probably isn't (12am should _subtract_ 
> 12, while 12pm does _not_ add 12).

But you have "if (hour > 0 && hour < 12)" in both am and pm so assignment to tm would not trigger...

> That said, I have a rice cooker that avoids the problem by saying "0:10 PM" 
> for ten minutes past midday ;)

You eat rice?

> Of course, all sane and civilized countries just use 24-hour format 
> anyway.

You are referring to the US, but neither is Japan sane nor civilized ;-).