Re: [PATCH] Teach the git wrapper about --name-rev and --name-rev-by-tags

From: Linus Torvalds <torvalds@osdl.org>
Date: Jul 28, 2006, 16:59 UTC
Message-ID: <Pine.LNX.4.64.0607280952200.4168@g5.osdl.org>
In-Reply-To: <Pine.LNX.4.63.0607281308280.29667@wbgn013.biozentrum.uni-wuerzburg.de>

On Fri, 28 Jul 2006, Johannes Schindelin wrote:

> 
> Now you can say
> 
> 	git --name-rev log

I think this is wrong.

It may be a straightforward translation of

> 	git log | git name-rev --stdin | less

but that doesn't make it any more "correct".

>From a logical standpoint, it should be an argument to the _logging_, not

to the main git binary, so it should be

	git log --name-rev

and you should do the parsing (and the output) inside revision.c.

Also, I doubt most people want every release named. I think the common case would be that you want those releases named that match heads (and tags in particular) _exactly_. If you want everything named, maybe you want to do "--name-rev-all" or something.

Hmm?

(That would also likely perform a lot better)

		Linus