Re: Slow fetches of tags

From: Linus Torvalds <torvalds@osdl.org>
Date: May 24, 2006, 19:17 UTC
Message-ID: <Pine.LNX.4.64.0605241200110.5623@g5.osdl.org>
In-Reply-To: <7v64jv8fdx.fsf@assigned-by-dhcp.cox.net>

On Wed, 24 May 2006, Junio C Hamano wrote:

> 
> A "have" object is not just has_sha1_file(), but it needs to be
> reachable from one of our tips we have already verified as
> complete

You're right.

And the strange part is that the commit we should give for the tag thing _should_ actually be pretty recent, and I wonder why we end up walking the whole damn tree history and saying "want" to basically them all.

IOW, I think there's something more fundamentally wrong with the tag following. We _should_ have figured out much more quickly that we have it all.

I'm starting to suspect that it's actually a tag-specific problem: we do that reachability crud all by commit history, so the tags are a total special case, and if we don't send the proper HAVE/WANT for those or mark them properly with THEY_HAVE/COMMON etc, maybe the algorithm just gets confused.

I need to go pick up my youngest, so I'll be off-line on this for a while. Will try to think it through.

		Linus