Re: [PATCH 3/3] Make clear_commit_marks() clean harder

From: Linus Torvalds <torvalds@osdl.org>
Date: Jul 3, 2006, 22:55 UTC
Message-ID: <Pine.LNX.4.64.0607031552410.12404@g5.osdl.org>
In-Reply-To: <Pine.LNX.4.63.0607032309190.29667@wbgn013.biozentrum.uni-wuerzburg.de>

On Mon, 3 Jul 2006, Johannes Schindelin wrote:

> 
> Traversing is actually wrong. Clearing the marks does not mean to clear 
> them on commits we did not even mark!

If we didn't mark them, then clearing them would be a no-op, so nobody really cares.

> But clearing on commits we _have_ -- but not parsed -- is important, 
> obviously.

Right. The point is, some logic can choose to mark commits UNINTERESTING without even parsing that commit, and it would be a good thing. You only need to parse the commit once you decide that you need its parents (or it's tree, of course), but you may be able to mark it uninteresting before that.

This is why it is _wrong_ to care about the "parsed" bit when clearing the flags.

		Linus