Re: [PATCH 4/3] Fold get_merge_bases_clean() into get_merge_bases()
- From
Linus Torvalds <torvalds@osdl.org>
- Date
- Jul 2, 2006, 21:17 UTC
- Message-ID
- <Pine.LNX.4.64.0607021414060.12404@g5.osdl.org>
- In-Reply-To
- <44A8339B.7070608@lsrfire.ath.cx>
On Sun, 2 Jul 2006, Rene Scharfe wrote:
> > I have an idea. Would it help to gather a list of all commit object > flags from the different files? And then we would come up with unique > names? And then move the definition of all of them to commit.h?
We already did that once, for a subset of the programs. Except we put them in revision.h instead ;)
And yes, we should probably do it for most of the rest.
Some of them (git-show-branch) have really special flags usage, and don't want to pollute their magic flags with anybody else at all, but most of the rest (fetch.c etc) have just a few flags and could in fact mostly re-use the standard ones.
Linus