git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] sha1_name.c: no need to include diff.h; tree-walk.h will do.

From
Linus Torvalds <torvalds@osdl.org>
Date
Apr 19, 2006, 20:50 UTC
Message-ID
<Pine.LNX.4.64.0604191348230.3701@g5.osdl.org>
In-Reply-To
<7v1wvt8hdb.fsf@assigned-by-dhcp.cox.net>
On Wed, 19 Apr 2006, Junio C Hamano wrote:
>
>  * Just a clean-up, comes on top of the one that returns mode
>    from get_tree_entry().
Ack (along with the mode addition).

However, since the function is now no longer private to the SHA1 name lookup, I wonder if it might not be more logically put into "tree-walk.c" instead of "sha1_name.c".

Just a thought.
		Linus
Previous: Junio C Hamano
Message 2 of 2 in “sha1_name.c: no need to include diff.h; tree-walk.h will do.”
  1. sha1_name.c: no need to include diff.h; tree-walk.h will do.Junio C Hamano, Apr 19, 2006
  2. Linus TorvaldsApr 19, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.