From: Linus Torvalds Date: Wed, 19 Apr 2006 20:50:48 GMT Subject: Re: [PATCH] sha1_name.c: no need to include diff.h; tree-walk.h will do. Message-ID: In-Reply-To: <7v1wvt8hdb.fsf@assigned-by-dhcp.cox.net> On Wed, 19 Apr 2006, Junio C Hamano wrote: > > * Just a clean-up, comes on top of the one that returns mode > from get_tree_entry(). Ack (along with the mode addition). However, since the function is now no longer private to the SHA1 name lookup, I wonder if it might not be more logically put into "tree-walk.c" instead of "sha1_name.c". Just a thought. Linus