Re: path limiting broken

From: Linus Torvalds <torvalds@osdl.org>
Date: Apr 16, 2006, 17:07 UTC
Message-ID: <Pine.LNX.4.64.0604161000550.3701@g5.osdl.org>
In-Reply-To: <Pine.LNX.4.63.0604161835410.17985@wbgn013.biozentrum.uni-wuerzburg.de>

On Sun, 16 Apr 2006, Johannes Schindelin wrote:

Show 10 quoted lines

> 
> But you missed my point. The file log-tree.c had some opt handling. I 
> changed it (as can be seen in my patch for combined diffstat), so the 
> merge did not go well with next, which removed that code.
> 
> So I tried to be clever and find the (non-merge) commit where this 
> happened. With what you describe, I should have hit *exactly one* commit 
> removing the code.
> 
> But I hit *exactly none* with "git log --cc master log-tree.c".

Do you have the tree somewhere?

In the current git tree, there really _is_ just one commit that touches log-tree.c in "master". And "git log log-tree.c" picks that out without trouble.

Did you mean to do

	git log --cc next log-tree.c

instead, perhaps? (Note the "next" branch specifier) That definitely shows three commits, including very much the one that moves the common option parsing to revision.c (do "git log --cc --full-diff next log-tree.c" if you want to see the whole diff whenever something touches log-tree.c).

Maybe I'm still missing something, but it seems to do the right thing for me..

		Linus