Re: path limiting broken

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Apr 16, 2006, 18:09 UTC
Message-ID: <Pine.LNX.4.63.0604162006050.19560@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <Pine.LNX.4.64.0604161052310.3701@g5.osdl.org>

Hi,

On Sun, 16 Apr 2006, Linus Torvalds wrote:

Show 14 quoted lines

> On Sun, 16 Apr 2006, Johannes Schindelin wrote:
> > 
> > I finally found the commit which removed parse_whatchanged_opt() from 
> > log-tree.c by
> > 
> > 	git-rev-list 4a617..next | while read commit; do \
> > 		echo $commit; \
> > 		git diff $commit^..$commit log-tree.c | \
> > 			grep parse_whatchanged; \
> > 	done | less
> 
> Heh. You really should learn about "-m -p", which does the above, but 
> better (it compares against _all_ parents - you would have missed the 
> thing _again_ if the "lt/logopt" branch had been the main branch ;)

Somehow I forgot. Probably because I don't like the format either.

Show 6 quoted lines

> [...] even
> 
> 	git show -c 43f934aa90
> 
> won't show that "log-tree.c" file AT ALL, because there was no content 
> conflict: the whole file was taken from one branch, unmodified.

There's another reason it does not show it. ATM, you have to add "-p" to the command line, or "-c" will not show *any* patch, let alone a combined one.

> So "--cc" really does ignore everything that is irrelevant for the end 
> result, and in this case you are very much trying to find somethign that 
> is totally irrelevant for the end result, since the function you look for 
> had never even _existed_ in the file as far as the end result goes..

Thanks for all your help, but in this case it was not irrelevant. Because I *had* the function in my working copy. And I had changed it. So I had to find out where to move the change.

Again, thanks a bunch, Dscho