Re: [RFH] Exploration of an alternative diff_delta() algorithm

From: Nicolas Pitre <nico@cam.org>
Date: Apr 9, 2006, 18:08 UTC
Message-ID: <Pine.LNX.4.64.0604091401560.2215@localhost.localdomain>
In-Reply-To: <20060409175316.GA21455@erlang.gbar.dtu.dk>

On Sun, 9 Apr 2006, Peter Eriksen wrote:

Show 6 quoted lines

> On Sun, Apr 09, 2006 at 01:40:14PM -0400, Nicolas Pitre wrote:
> ...
> > It also has lots of compilation warnings.
> 
> Hm, I don't get any warnings.  Would you mind pasting them, so I
> can see what it's about?

gcc -o diff-delta.o -c -g -O2 -Wall -DSHA1_HEADER='<openssl/sha.h>' diff-delta.c diff-delta.c: In function 'diff_delta': diff-delta.c:123: warning: pointer targets in passing argument 1 of 'init_hash' differ in signedness diff-delta.c:124: warning: pointer targets in passing argument 1 of 'init_hash' differ in signedness diff-delta.c:170: warning: pointer targets in passing argument 1 of 'hash' differ in signedness diff-delta.c:171: warning: pointer targets in passing argument 1 of 'hash' differ in signedness diff-delta.c:203: warning: pointer targets in passing argument 1 of 'init_hash' differ in signedness diff-delta.c:204: warning: pointer targets in passing argument 1 of 'init_hash' differ in signedness

Also you should avoid declaring new variables after code in the same scope, like you do with version_offset for example. This is a feature that many C compilers don't support.

Nicolas