Re: [RFH] Exploration of an alternative diff_delta() algorithm

From: Nicolas Pitre <nico@cam.org>
Date: Apr 9, 2006, 17:40 UTC
Message-ID: <Pine.LNX.4.64.0604091333140.2215@localhost.localdomain>
In-Reply-To: <Pine.LNX.4.64.0604091307460.2215@localhost.localdomain>

On Sun, 9 Apr 2006, Nicolas Pitre wrote:

Show 23 quoted lines

> On Sun, 9 Apr 2006, Peter Eriksen wrote:
> 
> > Greetings Gitlings,
> > 
> > I've been trying to implement an alternative algorithm
> > for diff_delta().  I'm getting close to something that
> > works, but now I'm stuck!
> 
> Nothing outside diff-delta.c and patch-delta.c is aware of the delta 
> data format.  So if your version is meant to be a transparent 
> replacement then it should pass all tests.  If it doesn't then it is 
> broken.
> 
> To help you play around you could try the test-delta utility (make 
> test-delta to build it).
> 
> So:
> 
> 	test-delta -d file1 file2 delta_file
> 	test-delta -p file1 delta_file file3
> 	cmp file2 file3
> 
> You should always have file3 identical to file2.

Out of curiosity I just tried your diff-delta version with test-delta and it produced a segmentation fault on the first attempt.

It also has lots of compilation warnings.

Nicolas