Re: Bad merging with stgit or git

From: Linus Torvalds <torvalds@osdl.org>
Date: Mar 21, 2006, 20:37 UTC
Message-ID: <Pine.LNX.4.64.0603211219230.3622@g5.osdl.org>
In-Reply-To: <20060321200847.GS18185@pasky.or.cz>

On Tue, 21 Mar 2006, Petr Baudis wrote:

> 
> With the old Git version (probably v1.1.4, but I'm not so sure when
> looking at 1.1.4's git-commit.sh), git-commit would happily do the
> commit, but wouldn't record the commit as a merge.

I considered that, but as far as I can tell, Mauro is actually using a fairly recent version of "git". How do I know? The second merge (the _real_ one) says

	commit 86d720ef82ca09e75fac06be15da7cbe2721863a
	Merge: e338b73... 8fce4d8...
	Author: Mauro Carvalho Chehab <mchehab@infradead.org>
	Date:   Fri Mar 10 01:32:32 2006 -0300

	    Merge branch 'origin'
    
	    Conflicts:
	    
	        drivers/media/video/saa7134/saa7134-dvb.c
	    nothing to commit

and that "Conflicts:" thing from git is actually reasonably recent (it's from end of January), and almost certainly doesn't exist in v1.1.4 (I don't think it exists in any 1.1.x version).

So it's 1.2.0 or newer (or some random build, of course).

And I _hope_ that no git that recent will commit a merge in progress.

However, it does look like the

	case "$all,$also" in
	,t)

case doesn't check for MERGE_HEAD. That could be the bug. Junio?

		Linus