Re: Bad merging with stgit or git

From: Petr Baudis <pasky@suse.cz>
Date: Mar 21, 2006, 20:08 UTC
Message-ID: <20060321200847.GS18185@pasky.or.cz>
In-Reply-To: <1142969653.4749.109.camel@praia>

Dear diary, on Tue, Mar 21, 2006 at 08:34:13PM CET, I got a letter where Mauro Carvalho Chehab <mchehab@infradead.org> said that...

Show 9 quoted lines

> With git-cat-file, it shows:
> 
> $ git-cat-file commit e338b736f1aee59b757130ffdc778538b7db18d6
> tree b233a18f740a2883e4863506175f671d821f1e5e
> parent cb31c70cdf1ac7034bed5f83d543f4888c39888a
> author Mauro Carvalho Chehab <mchehab@infradead.org> 1141965004 -0300
> committer Mauro Carvalho Chehab <mchehab@infradead.org> 1141965004 -0300
> 
> Merging Linus tree

Our IRC hypothesis:

gitweb shows two commits in sequence there,

	11 days ago Mauro Carvalho ...     Merge branch 'origin'
	11 days ago Mauro Carvalho ...     Merging Linus tree

where the "Merge branch 'origin'" commit is a true merge commit, but a rather boring one. There were conflicts during the merge, and according to mchebab they were "resolved" by (incorrectly) doing:

	...edit <files>...
	git-commit <files>

With the old Git version (probably v1.1.4, but I'm not so sure when looking at 1.1.4's git-commit.sh), git-commit would happily do the commit, but wouldn't record the commit as a merge.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
Right now I am having amnesia and deja-vu at the same time.  I think
I have forgotten this before.