Re: [RFH] zlib gurus out there?

From: Linus Torvalds <torvalds@osdl.org>
Date: Mar 8, 2006, 02:00 UTC
Message-ID: <Pine.LNX.4.64.0603071753370.32577@g5.osdl.org>
In-Reply-To: <7vslptivbg.fsf@assigned-by-dhcp.cox.net>

On Tue, 7 Mar 2006, Junio C Hamano wrote:

> >
> > No, I don't think that's good. You're only doing a partial deflate, you 
> > can't ask for a Z_FULL_FLUSH. That only works if you give it the whole 
> > buffer, and you don't.

Actually, I misread what you were trying to do, and thought this was the inflate phase, not the deflate. Now that I understand what you want,

Show 7 quoted lines

> So, in short there is no way to create:
> 
>     hdr part deflated.
>     flush.
>     data part deflated independently.
> 
> and have the current sha1_read_file() not to notice that flush,

Actually, try the patch you already tried, except you'll need to add a

	deflateEnd(&stream);
	deflateInit(&stream, Z_BEST_COMPRESSION);
	.. set up output parameters again ..

and you need to change the initial

	size = deflateBound(&stream, len+hdrlen);

to

	size = deflateBound(&stream, len) + deflateBound(&stream, hdrlen);

and then you might be ok.

That said, I'm not sure I agree with what you're trying to do.

		Linus