Re: [RFH] zlib gurus out there?

From: Linus Torvalds <torvalds@osdl.org>
Date: Mar 8, 2006, 00:59 UTC
Message-ID: <Pine.LNX.4.64.0603071658300.32577@g5.osdl.org>
In-Reply-To: <7vzmk1izpa.fsf_-_@assigned-by-dhcp.cox.net>

On Tue, 7 Mar 2006, Junio C Hamano wrote:

Show 11 quoted lines

> 
> However, I am stuck with the first step, which is to do a full
> flush after the header.  An obvious change to the code quoted
> above writes out a corrupt object:
> 
> 	/* First header.. */
> 	stream.next_in = hdr;
> 	stream.avail_in = hdrlen;
> -	while (deflate(&stream, 0) == Z_OK)
> +	while (deflate(&stream, Z_FULL_FLUSH) == Z_OK)
> 		/* nothing */;

No, I don't think that's good. You're only doing a partial deflate, you can't ask for a Z_FULL_FLUSH. That only works if you give it the whole buffer, and you don't.

iirc, wtf, wdik, and ianal.

		Linus