git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Fix object re-hashing

From
Linus Torvalds <torvalds@osdl.org>
Date
Feb 12, 2006, 18:10 UTC
Message-ID
<Pine.LNX.4.64.0602121006360.3691@g5.osdl.org>
In-Reply-To
<Pine.LNX.4.64.0602120956130.3691@g5.osdl.org>
On Sun, 12 Feb 2006, Linus Torvalds wrote:
> 
> I actually didn't see any of this trigger in real life, so maybe my 
> analysis is wrong. Junio? Johannes?

Btw, if it does trigger, the behaviour would be that a subsequent object lookup will fail, because the last old slot would be NULL, and a few entries following it (likely just a couple - never mind that the event triggering in the first place is probably fairly rare) wouldn't have gotten re-hashed down.

As a result, we'd allocate a new object, and have _two_ "struct object"s that describe the same real object. I don't know what would get upset, but git-fsck-index certainly would be (one of them would likely be marked unreachable, because lookup wouldn't find it, but you might have other issues too).

			Linus
Previous: Linus TorvaldsNext: Junio C Hamano
Message 2 of 13 in “Fix object re-hashing”
  1. Linus TorvaldsFeb 12, 2006
  2. Linus TorvaldsFeb 12, 2006
  3. Junio C HamanoFeb 12, 2006
  4. Linus TorvaldsFeb 12, 2006
  5. Linus TorvaldsFeb 12, 2006
  6. Junio C HamanoFeb 12, 2006
  7. Linus TorvaldsFeb 12, 2006
  8. Johannes SchindelinFeb 12, 2006
  9. Linus TorvaldsFeb 13, 2006
  10. Johannes SchindelinFeb 13, 2006
  11. Junio C HamanoFeb 12, 2006
  12. Linus TorvaldsFeb 12, 2006
  13. Linus TorvaldsFeb 12, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.