From: Linus Torvalds Date: Sun, 12 Feb 2006 18:10:02 GMT Subject: Re: Fix object re-hashing Message-ID: In-Reply-To: On Sun, 12 Feb 2006, Linus Torvalds wrote: > > I actually didn't see any of this trigger in real life, so maybe my > analysis is wrong. Junio? Johannes? Btw, if it does trigger, the behaviour would be that a subsequent object lookup will fail, because the last old slot would be NULL, and a few entries following it (likely just a couple - never mind that the event triggering in the first place is probably fairly rare) wouldn't have gotten re-hashed down. As a result, we'd allocate a new object, and have _two_ "struct object"s that describe the same real object. I don't know what would get upset, but git-fsck-index certainly would be (one of them would likely be marked unreachable, because lookup wouldn't find it, but you might have other issues too). Linus