Re: [PATCH 1/9] archimport: first, make sure it still compiles
- From
Linus Torvalds <torvalds@osdl.org>
- Date
- Nov 24, 2005, 18:54 UTC
- Message-ID
- <Pine.LNX.4.64.0511241051170.13959@g5.osdl.org>
- In-Reply-To
- <20051124074739.GB4789@mail.yhbt.net>
Eric, I don't know about Junio, but if I were him, I'd have preferred that all your patches had a
archimport: ..
prefix in the subject line, not just the first one.
For example, if you just merge the patches as-is now, and then look at the end result with gitk (or any of the tools that show the shortlog format: just the first line of the commit), you get explanations like
fix -t tmpdir switch
which is clearly _correct_, but it's much nicer if they show which area was implied, ie
archimport: fix -t tmpdir switch
so that you can tell from the shortlog whether it was a "global" change, or somethign that affected a specific program.
Just a suggestion,
Linus