Re: gitk shows an empty line between "Comments" and changed files

From: Linus Torvalds <torvalds@osdl.org>
Date: Oct 28, 2005, 23:00 UTC
Message-ID: <Pine.LNX.4.64.0510281557580.3348@g5.osdl.org>
In-Reply-To: <1130539503.10531.43.camel@dv>

On Fri, 28 Oct 2005, Pavel Roskin wrote:

Show 12 quoted lines

> > 
> > I do not oppose dropping the commit-id line from the default
> > output, but having it optionally available would be useful in
> > one application.  Somebody _could_ write a tool that does
> > something like:
> > 
> >     git-rev-list ^$old_head $new_head |
> >     git-diff-tree -p -m --stdin --with-commit-ids |
> >     git-patch-id
> 
> Sounds good.  Perhaps the commit IDs should have a prefix identifying
> them.

Guys, why do you want to drop it? We've always had it, and it doesn't really hurt.

Yes, gitk got a new empty line because I didn't realize that the output of "git-diff-tree $commit" is slightly different from "git-diff-tree $t2 $t2", but hey, that was due to a gitk change, and I think it should be trivial for gitk to just react to it.

So if we add a new flag, please make it go the other way: one that makes the output really quiet, but keeps the standard output the same.

		Linus