git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: gitk shows an empty line between "Comments" and changed files

From
PRPavel Roskin <proski@gnu.org>
Date
Oct 28, 2005, 01:36 UTC
Message-ID
<1130463389.2186.14.camel@dv>
In-Reply-To
<7vslum3l2w.fsf@assigned-by-dhcp.cox.net>
Hi, Junio!
On Thu, 2005-10-27 at 10:51 -0700, Junio C Hamano wrote:
Show 6 quoted lines
> Pavel Roskin <proski@gnu.org> writes:
> 
> > Or maybe the SHA1 header should never be printed at all?  It looks like
> > it's not documented anywhere.  It doesn't break the tests.
> 
> AFAIK, its only user (except humans) is patch-id.

Thank you for reply! git-patch-id is badly documented, and its output is not documented at all. It outputs two SHA1 hashes, and the second one is taken from the line produced by git-diff-tree. If there is no such line, the second ID is 0.

git-patch-id is only used by git-cherry. git-cherry writes the second SHA1 to some files in a temporary directory, but it never reads those files, it only checks that they exist.

I'm pretty confident now that the patch I posted in the last message was correct.

Of course, more cleanup will be needed to remove the second ID from git-patch-id, to adjust git-cherry accordingly and to remove "p" assignments in gitk.

-- 
Regards,
Pavel Roskin
Previous: Junio C HamanoNext: Junio C Hamano
Message 3 of 11 in “gitk shows an empty line between "Comments" and changed files”
  1. Pavel RoskinOct 27, 2005
  2. Junio C HamanoOct 27, 2005
  3. Pavel RoskinOct 28, 2005
  4. Junio C HamanoOct 28, 2005
  5. Pavel RoskinOct 28, 2005
  6. Linus TorvaldsOct 28, 2005
  7. Junio C HamanoOct 29, 2005
  8. Linus TorvaldsOct 29, 2005
  9. Pavel RoskinOct 29, 2005
  10. Linus TorvaldsOct 29, 2005
  11. Pavel RoskinOct 29, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.