Re: daemon.c broken on OpenBSD

From: Linus Torvalds <torvalds@osdl.org>
Date: Oct 24, 2005, 17:58 UTC
Message-ID: <Pine.LNX.4.64.0510241054480.10477@g5.osdl.org>
In-Reply-To: <435D1963.8070205@zytor.com>

On Mon, 24 Oct 2005, H. Peter Anvin wrote:

> 
> A much more likely cause for problems would be system headers that use the
> isxxx() macros as part of other macros.  That would be in violation of POSIX,
> but is reasonably common.

Hmm.. Yes, that's a good point. I don't see what thing could do it that we care about (and since we do actually do a pretty valid ctype implementation, it should all work out right regardless), but yes, it might be safer to rename the things.

Especially if we then continue to make sure _not_ to include <ctype.h> ourselves, so that only systems with broken headers (like the ones on OpenBSD ;) could ever use the standard names anyway. That way we'd not have to worry whether somebody uses them by mistake..

Btw, nobody ever replied to my question whether we might be using something else that is locale-specific. I'm not actually locate-aware enough to even know what else than <ctype.h> might be dangerous to use..

Anybody?

		Linus