git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: daemon.c broken on OpenBSD

From
Linus Torvalds <torvalds@osdl.org>
Date
Oct 24, 2005, 16:02 UTC
Message-ID
<Pine.LNX.4.64.0510240901020.10477@g5.osdl.org>
In-Reply-To
<867jc336f4.fsf@blue.stonehenge.com>
On Sun, 23 Oct 2005, Randal L. Schwartz wrote:
> 
> If that rings a bell, help me out here.  I'm guessing "isalnum" is getting
> defined (wrongly).  Yeah, looks like in cache.h.  Why is this getting
> defined?
We're doing our own ctype.h.

The fix is to make sure that "cache.h" is included _after_ system includes.

iow, this should fix it, methinks.
		Linus
---
diff --git a/daemon.c b/daemon.c
index 0c6182f..6e5de11 100644
--- a/daemon.c
+++ b/daemon.c
@@ -1,5 +1,3 @@
-#include "cache.h"
-#include "pkt-line.h"
 #include <signal.h>
 #include <sys/wait.h>
 #include <sys/socket.h>
@@ -10,6 +8,9 @@
 #include <arpa/inet.h>
 #include <syslog.h>
 
+#include "cache.h"
+#include "pkt-line.h"
+
 static int log_syslog;
 static int verbose;
 
Previous: Randal L. SchwartzNext: Randal L. Schwartz
Message 7 of 16 in “daemon.c broken on OpenBSD”
  1. Randal L. SchwartzOct 24, 2005
  2. Junio C HamanoOct 24, 2005
  3. Matthias UrlichsOct 24, 2005
  4. Randal L. SchwartzOct 25, 2005
  5. Randal L. SchwartzOct 25, 2005
  6. Randal L. SchwartzOct 25, 2005
  7. Linus TorvaldsOct 24, 2005
  8. Randal L. SchwartzOct 24, 2005
  9. Linus TorvaldsOct 24, 2005
  10. H. Peter AnvinOct 24, 2005
  11. Linus TorvaldsOct 24, 2005
  12. H. Peter AnvinOct 24, 2005
  13. Linus TorvaldsOct 24, 2005
  14. H. Peter AnvinOct 24, 2005
  15. Morten WelinderOct 24, 2005
  16. Junio C HamanoOct 24, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.