Re: [PATCH] Rename warn() to warning() to fix symbol conflicts on BSD and Mac OS

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mar 31, 2007, 10:46 UTC
Message-ID: <Pine.LNX.4.63.0703311245510.4045@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <7vejn5ygkc.fsf@assigned-by-dhcp.cox.net>

Hi,

On Sat, 31 Mar 2007, Junio C Hamano wrote:

Show 16 quoted lines

> Theodore Ts'o <tytso@mit.edu> writes:
> 
> > This fixes a problem reported by Randal Schwartz:
> >
> >>I finally tracked down all the (albeit inconsequential) errors I was getting
> >>on both OpenBSD and OSX.  It's the warn() function in usage.c.  There's
> >>warn(3) in BSD-style distros.  It'd take a "great rename" to change it, but if
> >>someone with better C skills than I have could do that, my linker and I would
> >>appreciate it.
> >
> > It was annoying to me, too, when I was doing some mergetool testing on
> > Mac OS X, so here's a fix.
> 
> I'd take this for now, but I wonder where we should stop.  If
> somebody exports error() or die(), would we end up renaming them
> to git_error() and git_die()?

Libification, here we come ;-)

Ciao, Dscho