git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Rename warn() to warning() to fix symbol conflicts on BSD and Mac OS

From
Junio C Hamano <junkio@cox.net>
Date
Mar 31, 2007, 08:15 UTC
Message-ID
<7vejn5ygkc.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<11752960251394-git-send-email-tytso@mit.edu>
Theodore Ts'o <tytso@mit.edu> writes:
Show 10 quoted lines
> This fixes a problem reported by Randal Schwartz:
>
>>I finally tracked down all the (albeit inconsequential) errors I was getting
>>on both OpenBSD and OSX.  It's the warn() function in usage.c.  There's
>>warn(3) in BSD-style distros.  It'd take a "great rename" to change it, but if
>>someone with better C skills than I have could do that, my linker and I would
>>appreciate it.
>
> It was annoying to me, too, when I was doing some mergetool testing on
> Mac OS X, so here's a fix.

I'd take this for now, but I wonder where we should stop. If somebody exports error() or die(), would we end up renaming them to git_error() and git_die()?

Previous: Theodore Ts'oNext: Johannes Schindelin
Message 2 of 5 in “Rename warn() to warning() to fix symbol conflicts on BSD and Mac OS”
  1. Rename warn() to warning() to fix symbol conflicts on BSD and Mac OSTheodore Ts'o, Mar 30, 2007
  2. Junio C HamanoMar 31, 2007
  3. Johannes SchindelinMar 31, 2007
  4. Randal L. SchwartzMar 31, 2007
  5. Alex RiesenApr 1, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.