git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] bisect: show the maximal number of commits to be tested

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Mar 22, 2007, 02:15 UTC
Message-ID
<Pine.LNX.4.63.0703220314440.4045@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To
<7vhcsexcc3.fsf@assigned-by-dhcp.cox.net>
Hi,
On Wed, 21 Mar 2007, Junio C Hamano wrote:
Show 31 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > Since git-bisect already asks rev-list to find the midpoint (and rev-list
> > consequently counts the number of commits), rev-list can pass it the
> > maximal number of commits.
> >
> > As a bonus, this avoids an extra call to rev-list.
> >
> > Miscalculation noticed by Uwe, implementation suggested by Linus.
> >
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > ---
> >
> > 	On Wed, 21 Mar 2007, Linus Torvalds wrote:
> >
> > 	> On Wed, 21 Mar 2007, Uwe Kleine-König wrote:
> > 	> >
> > 	> > Up to now the number printed was calculated assuming that the 
> > 	> > current revision to test is bad.  Given that it's not possible 
> > 	> > that this always matches the number of suspicious revs if the 
> > 	> > current one is good, the maximum of both is taken now.
> > 	> 
> > 	> How about adding a new flag to "git-rev-list", to make it count 
> > 	> both ways?
> >
> > 	Did I understand you correctly?
> 
> Why not show both, or at least total?
> 
> This and the earlier optimization patch steps on each others
> toes, ouch ;-).
Yes... on both accounts. I'll let your patches settle first, and resubmit.

Ciao, Dscho

Previous: Junio C HamanoNext: Junio C Hamano
Message 16 of 18 in “[BUG] bisecting miscounts revisions left to test”
  1. Uwe Kleine-KönigMar 16, 2007
  2. Johannes SchindelinMar 17, 2007
  3. Uwe Kleine-KönigMar 17, 2007
  4. calculate the maximal number of revisions to testUwe Kleine-König, Mar 17, 2007
  5. Johannes SchindelinMar 17, 2007
  6. Uwe Kleine-KönigMar 17, 2007
  7. Bisect: fix calculation of the number of suspicious revisionsUwe Kleine-König, Mar 21, 2007
  8. Junio C HamanoMar 21, 2007
  9. Uwe Kleine-KönigMar 21, 2007
  10. Uwe Kleine-KönigMar 21, 2007
  11. Junio C HamanoMar 21, 2007
  12. Linus TorvaldsMar 21, 2007
  13. Junio C HamanoMar 22, 2007
  14. bisect: show the maximal number of commits to be testedJohannes Schindelin, Mar 22, 2007
  15. Junio C HamanoMar 22, 2007
  16. Johannes SchindelinMar 22, 2007
  17. 1/2 git-rev-list: add --bisect-vars option.Junio C Hamano, Mar 22, 2007
  18. 2/2 git-rev-list --bisect: optimizationJunio C Hamano, Mar 22, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.