Re: [PATCH] calculate the maximal number of revisions to test

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mar 17, 2007, 17:49 UTC
Message-ID: <Pine.LNX.4.63.0703171845541.22628@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <20070317141209.GA7838@cepheus>

Hi zeisberg,

the subject really could use a "bisect:" prefix, and maybe be a little clearer to begin with? Imagine how much sense it makes to read the commit messages, and see that some maximal number of revisions is calculated.

On Sat, 17 Mar 2007, Uwe Kleine-König wrote:

Show 18 quoted lines

> diff --git a/git-bisect.sh b/git-bisect.sh
> index b1c3a6b..a5b4fdd 100755
> --- a/git-bisect.sh
> +++ b/git-bisect.sh
> @@ -150,8 +150,14 @@ bisect_next() {
>  	    git-diff-tree --pretty $rev
>  	    exit 0
>  	fi
> -	nr=$(eval "git-rev-list $rev $good -- $(cat $GIT_DIR/BISECT_NAMES)" | wc -l) || exit
> -	echo "Bisecting: $nr revisions left to test after this"
> +	nr_bad=$(eval "git-rev-list $rev^ $good -- $(cat $GIT_DIR/BISECT_NAMES)" | wc -l) || exit
> +	nr_good=$(eval "git-rev-list $bad^ ^$rev $good -- $(cat $GIT_DIR/BISECT_NAMES)" | wc -l) || exit
> +	if test "$nr_bad" -ge "$nr_good"; then
> +		nr="$nr_bad";
> +	else
> +		nr="$nr_good";
> +	fi;
> +	echo "Bisecting: maximal $nr revisions left to test after this"

How about this instead:

- echo "Bisecting: $nr revisions left to test after this" + echo "Bisecting: approx. $nr revisions left to test after this"

since your version is an approximation (although a conservative one) anyway. Hmm?

Ciao, Dscho