git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Make gc a builtin.

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Mar 14, 2007, 01:05 UTC
Message-ID
<Pine.LNX.4.63.0703140203250.22628@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To
<11738270273757-git-send-email-jbowes@dangerouslyinc.com>
Hi,
On Tue, 13 Mar 2007, James Bowes wrote:
> Take 3. The changes are pretty much all of Shawn's suggestions. If a 
> command fails this code just returns -1, rather than calling error(), so 
> that two duplicate error messages aren't printed out.

If you say "return error(...);", there is _no_ way that multiple error messages are printed out.

If you say "return -1;", however, the user is likely to _never_ know that git-gc failed. (I, for one, do not check $? after running a program which does not say _anything_.)

Ciao, Dscho

Previous: James BowesNext: Brian Gernhardt
Message 2 of 3 in “Make gc a builtin.”
  1. Make gc a builtin.James Bowes, Mar 13, 2007
  2. Johannes SchindelinMar 14, 2007
  3. Brian GernhardtMar 14, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.