From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Wed, 14 Mar 2007 01:05:11 GMT
Subject: Re: [PATCH] Make gc a builtin.
Message-ID: <Pine.LNX.4.63.0703140203250.22628@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <11738270273757-git-send-email-jbowes@dangerouslyinc.com>

Hi,

On Tue, 13 Mar 2007, James Bowes wrote:

> Take 3. The changes are pretty much all of Shawn's suggestions. If a 
> command fails this code just returns -1, rather than calling error(), so 
> that two duplicate error messages aren't printed out.

If you say "return error(...);", there is _no_ way that multiple error 
messages are printed out.

If you say "return -1;", however, the user is likely to _never_ know that 
git-gc failed. (I, for one, do not check $? after running a program which 
does not say _anything_.)

Ciao,
Dscho