Re: [PATCH] Add git-config --remove-section, document --rename-section

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mar 2, 2007, 15:44 UTC
Message-ID: <Pine.LNX.4.63.0703021640440.22628@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <45E814D9.7020104@lu.unisi.ch>

Hi,

On Fri, 2 Mar 2007, Paolo Bonzini wrote:

Show 17 quoted lines

> > Of course you would have to move "int removing" and the related two 
> > lines to rename_section(), too.
> > 
> > The diff would be shorter, and if you then rename the function to 
> > rename_or_remove_section() it becomes all clearer.
> 
> It's more different than it looks like.  For example, remove_section needs this,
> 
>         if (buf[i] == '[') {
>                 if (section_name_match (&buf[i + 1], name)) {
> 		} else
> 			...
> 	}
> 
> while rename_section can use
> 
>         if (buf[i] == '[' && section_name_match (&buf[i+1], old_name)) {

But it does not have to.

	if (buf[i] == '[') {
		if (section_name_match(&buf[i + 1], old_name) {
			if (new_name == NULL)
				remove = 1;
			else
				/* write new section */
			continue;
		}
		remove = 0;
	}
	if (!remove)
		/* write buf */

Ciao, Dscho