Re: Memory overrun in http-push.c

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mar 1, 2007, 17:11 UTC
Message-ID: <Pine.LNX.4.63.0703011802130.22628@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <20070301120042.GD63606@codelabs.ru>

Hi,

On Thu, 1 Mar 2007, Eygene Ryabinkin wrote:

Show 5 quoted lines

> By the way, I am missing one thing: the Id keyword in the file. The 
> problem is that when some user is telling me: there is a bug in the 
> function a() that is inside the file b.c, then I can ask him to give me 
> the $Id$ tag of the file and I will have the full information about the 
> file version.

The problem is: Git does not track files, but rather trees. So, there is no sane way to add an Id.

But all is not lost! If your colleague sends you the offending file, you can calculate the object name from it by

	$ git-hash-object -t blob <filename>

If the file is too big, your colleague can run it herself and send you the object name (it is a 40 character hex string, but the first 8 or so should really be sufficient).

Then you can run

	$ git log -p HEAD <filename>

in your repository, and search for "index <object name>". You will find the commit which changed the file _from_ the state your colleague is seeing.

The idea is that the diff shows not only the names, but also a line "index <abbrev1>..<abbrev2>", where the abbrev's are the abbreviated object names of the old and new versions of that file.

BTW we had a similar discussion a while ago, which made me even write a patch for git-name-rev to name objects, too, but it was rejected as the workflow I outlined above is already sufficient for your use case.

Hth, Dscho