Re: Memory overrun in http-push.c

From: Junio C Hamano <junkio@cox.net>
Date: Mar 1, 2007, 09:32 UTC
Message-ID: <7vslcpux62.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <81b0412b0703010015l5c91c68pd4748ae379db98bb@mail.gmail.com>

"Alex Riesen" <raa.lkml@gmail.com> writes:

Show 6 quoted lines

> On 3/1/07, Eygene Ryabinkin <rea-git@codelabs.ru> wrote:
>> As Johannes pointed out, old habits are still alive. And when some
>> tool serves me the right way, I am happy with it. To make the patch
>> with Git I should create repository, hack there, merge it to the
>
> hacking on Git you already have a git repo, don't you?

You do not have to insist on using git to hack on git itself. I was more annoyed by the fact that the patch was an attachment, than it was generated by diff without leading a/ and b/ paths.

Being able to accept a patch that was made against freshly extracted tarball distribution is a good thing. I can take diffs generated by GNU diff against released tarballs just fine.

If you make it a requirement to send even an trivially obvious patch from controlled source, it would make the barrier to contribute much higher. Once you make it hard enough to submit patches, you will end up seeing only whining without patches on this list. I do not think we want to go in that direction.