Re: [PATCH] Teach 'git apply' to look at $GIT_DIR/config

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 18, 2007, 01:29 UTC
Message-ID: <Pine.LNX.4.63.0702180226480.22628@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <7vhctkp8gk.fsf@assigned-by-dhcp.cox.net>

Hi,

On Sat, 17 Feb 2007, Junio C Hamano wrote:

Show 12 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > And I use git-apply to apply patches way more often than "patch" these 
> > days. And I _think_ that it is a feature that it does not cd-up before 
> > trying to apply the stuff. In git.git, I cannot think of a reasonable use 
> > case for applying something not relative-to-root, but I had that use case 
> > in some other (git-tracked) project.
> >
> > So my vote is to leave the cwd where it is in git-apply.
> 
> I strongly disagree from my recent day-job experience. [Explains a 
> convincing use case in favour of cd-up.]

Hmm. I have to think about that. But a consequence of what you suggest would be to disallow git-apply outside of a repository, because then you would introduce _another_ inconsistency (git-apply without --index would behave differently when inside a repo than when outside of one).

Ciao, Dscho