Re: [PATCH] Teach 'git apply' to look at $GIT_DIR/config
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Feb 18, 2007, 00:08 UTC
- Message-ID
- <Pine.LNX.4.63.0702180107250.22628@wbgn013.biozentrum.uni-wuerzburg.de>
- In-Reply-To
- <7vmz3cqs3d.fsf@assigned-by-dhcp.cox.net>
Hi,
On Sat, 17 Feb 2007, Junio C Hamano wrote:
Show 21 quoted lines
> Jeff King <peff@peff.net> writes:
>
> > On Sat, Feb 17, 2007 at 01:12:52PM -0800, Junio C Hamano wrote:
> >
> >> + prefix = setup_git_directory_gently(&is_not_gitdir);
> >> + prefix_length = prefix ? strlen(prefix) : 0;
> >> + if (!is_not_gitdir) {
> >> + git_config(git_apply_config);
> >> + if (apply_default_whitespace)
> >> + parse_whitespace_option(apply_default_whitespace);
> >> + }
> >> +
> >
> > If I read this correctly, running 'git apply' inside a git repository
> > will parse $GIT_DIR/config and $HOME/.gitconfig. However, outside of a
> > repository it will parse neither. It would make more sense to me to
> > still parse $HOME/.gitconfig to pick up the user's global options.
>
> I thought about that, but decided against it. If you are truly
> operating outside a git managed repository, it does not feel
> right to apply configuration user has for git.That is a good point. But in the same vein, why not have a flag to git-apply, and let it ignore the configuration altogether?
Ciao, Dscho