Re: git log filtering

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 9, 2007, 15:02 UTC
Message-ID: <Pine.LNX.4.63.0702091557420.22628@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <20070209132239.GA727@coredump.intra.peff.net>

Hi,

On Fri, 9 Feb 2007, Jeff King wrote:

Show 10 quoted lines

> On Fri, Feb 09, 2007 at 02:13:18PM +0100, Johannes Schindelin wrote:
> 
> > The difference, of course, is that with the "other things", we either have 
> > no alternative (if you do not have curl, you cannot use HTTP transport), 
> > or we have workalikes (if you don't use openssl, the (possibly slower) 
> > SHA1 replacements take effect).
> 
> I'm not a pcre expert, but I thought most of the additions to posix
> extended regular expressions were expressed through constructs that
> would otherwise be invalid patterns.

So, once pcre is used, you can use these constructs. Even in scripts. Which just so happen to break on platforms where git is not compiled with pcre support.

Or do you suggest checking (in git!) if the pattern is a pcre special or not? That would be insane.

Show 6 quoted lines

> > We _used_ to rely on external "diff" and "merge", but have them as 
> > inbuilt components, exactly to avoid "if you have a slightly differing 
> > setup, git behaves differently".
> 
> But you're OK with "if you didn't built against curl, http transport 
> just doesn't work."

Yes, I am. Since HTTP is itself only a second-class citizen.

> So what if there is a '--pcre' option and a corresponding config option? 
> Thus you get the same results always, unless you use --pcre and it's not 
> built, in which case git dies. That seems to be the moral equivalent of 
> the curl situation.

I might be wrong, but most of git does not depend on HTTP.

> At any rate, you didn't address my original point, which is _all_ of 
> those options have drawbacks. I think the drawbacks of re-writing or 
> re-packaging a regular expression library outweigh those of adding the 
> dependency (or even having slightly irregular behavior).

This is only because you do not really have problems with dependencies. You just install, or compile, the dependent thing, which happens to be no hassle, since you use Linux. And you can compile & install things.

Once everybody runs Linux, and is allowed to compile & install things, I will no longer complain about trillions of dependencies.

Ciao, Dscho