Re: git log filtering

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 9, 2007, 00:18 UTC
Message-ID: <Pine.LNX.4.63.0702090115180.22628@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <20070208223336.GA9422@coredump.intra.peff.net>

Hi,

On Thu, 8 Feb 2007, Jeff King wrote:

Show 8 quoted lines

> On Thu, Feb 08, 2007 at 07:06:25PM +0100, Johannes Schindelin wrote:
> 
> > May I register a complaint? This is yet _another_ dependency.
> 
> Unlike other dependencies, I think it's quite natural to make it a
> conditional dependency. If you have pcre, you get more featureful
> regular expressions. If you don't, you get posix regular expressions.
> Do you object to a few extra lines in the Makefile?

Yes, I do. Not because of the extra lines, but because of the inconsistent interface.

We included libxdiff _exactly_ to ensure consistency between different git installations (remember, diff behaves quite differently on different platforms, and even GNU diff behaves differently depending on which version you use).

So no, I do not like the idea of using git on some random box, only to realize that what I have grown used to does not work.

Ciao, Dscho