git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC/PATCH] fast-import: Fix compile warnings

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Feb 7, 2007, 17:35 UTC
Message-ID
<Pine.LNX.4.63.0702071829450.22628@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To
<7vzm7p7uf9.fsf@assigned-by-dhcp.cox.net>
Hi,
On Wed, 7 Feb 2007, Junio C Hamano wrote:
Show 8 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > Not on all platforms are size_t and unsigned long equivalent.
> > Since I do not know how portable %z is, I play safe, and just
> > cast the respective variables to unsigned long.
> 
> The format "%s %lu" is consistent with what write_sha1_file_prepare()
> and unpack_sha1_header() uses, so that should be safe enough.

So, should we cast to (unsigned long) to make the gcc warning go away, or do we not care at all?

> However, your patch does not apply.

Hmm. Strange, I thought that I only changed the in_merge_bases() line... Will have a look tomorrow.

Ciao, Dscho

Previous: Junio C HamanoNext: Junio C Hamano
Message 4 of 8 in “fast-import: Fix compile warnings”
  1. fast-import: Fix compile warningsJohannes Schindelin, Feb 7, 2007
  2. Alex RiesenFeb 7, 2007
  3. Junio C HamanoFeb 7, 2007
  4. Johannes SchindelinFeb 7, 2007
  5. Junio C HamanoFeb 7, 2007
  6. Shawn O. PearceFeb 8, 2007
  7. Junio C HamanoFeb 8, 2007
  8. Shawn O. PearceFeb 8, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.